From 810783dc7c7200fcb613c7d0919f6c8a7bbbebb9 Mon Sep 17 00:00:00 2001 From: David Lane <42013603+ReenigneArcher@users.noreply.github.com> Date: Fri, 8 May 2026 00:59:22 -0400 Subject: [PATCH] build(windows): Always setup Node.js in Windows CI (#5084) --- .github/workflows/ci-windows.yml | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci-windows.yml b/.github/workflows/ci-windows.yml index 2e1075178..b0a9caa84 100644 --- a/.github/workflows/ci-windows.yml +++ b/.github/workflows/ci-windows.yml @@ -111,7 +111,6 @@ jobs: dependencies+=( "mingw-w64-${TOOLCHAIN}-MinHook" "mingw-w64-${TOOLCHAIN}-nsis" - "mingw-w64-${TOOLCHAIN}-nodejs" ) fi @@ -177,14 +176,11 @@ jobs: dotnet-version: '10.x' - name: Setup NodeJS - # Clang compiled NodeJS has issues when running rollup webpack - if: matrix.msystem != 'ucrt64' uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 with: node-version: 'lts/*' - name: NodeJS Path - if: matrix.msystem != 'ucrt64' shell: pwsh run: | # get NodeJS PATH @@ -226,10 +222,8 @@ jobs: COMMIT: ${{ inputs.release_commit }} run: | # setup NodeJS PATH - if [[ "${MATRIX_MSYSTEM}" != "ucrt64" ]]; then - NODEJS_PATH=$(cygpath "$NODEJS_PATH") - export PATH="$PATH:$NODEJS_PATH" - fi + NODEJS_PATH=$(cygpath "$NODEJS_PATH") + export PATH="$PATH:$NODEJS_PATH" mkdir -p build cmake \